Skip to content

Conversation

@zzacharo
Copy link

@zzacharo zzacharo commented Feb 8, 2024

Summary

At the moment the module hardcodes the mod_security debug level to 0 although it allows users to configure the debug log path. This PR introduces a new parameter called debug_log_level to be able to configure the SecDebugLogLevel.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@zzacharo zzacharo requested review from a team, bastelfreak, ekohl and smortex as code owners February 8, 2024 09:52
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@traylenator
Copy link
Contributor

Re the CLA CERN IT has an agreement with Puppetlabs that we have signed the CLA.

@zzacharo zzacharo force-pushed the parametrize-debug-log-level branch from 5b2c37a to fc46598 Compare February 8, 2024 10:40
@zzacharo
Copy link
Author

@smortex any chance to integrate this soon-ish?

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a more complete version of #2523. However, I can't merge it because of the CLA check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants